Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PF TF integration tests #2254

Merged
merged 17 commits into from
Aug 20, 2024
Merged

PF TF integration tests #2254

merged 17 commits into from
Aug 20, 2024

Conversation

VenelinMartinov
Copy link
Contributor

@VenelinMartinov VenelinMartinov commented Jul 26, 2024 •
edited
Loading

This moves some of the tf integration test code so that it can be used in PF and adds some PF TF integration tests.

@VenelinMartinov VenelinMartinov mentioned this pull request Jul 26, 2024
Merged
@VenelinMartinov VenelinMartinov marked this pull request as ready for review July 30, 2024 09:09
t0yv0
t0yv0 reviewed Jul 30, 2024
View reviewed changes
pkg/tests/tfcheck/tfcheck.go Outdated Show resolved Hide resolved
t0yv0
t0yv0 approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a few cleanup suggestions but not to stop this from merging, highly expedient to have this in, thank you!

@mjeffryes mjeffryes added this to the 0.108 milestone Aug 16, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 20, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.97260% with 19 lines in your changes missing coverage. Please review.

Project coverage is 56.99%. Comparing base (278e894) to head (5c828e7).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/tests/tfcheck/tfcheck.go 61.76% 13 Missing ⚠️
...f/tests/internal/providerbuilder/build_provider.go 84.61% 5 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2254   +/-   ##
=======================================
  Coverage   56.99%   56.99%           
=======================================
  Files         366      366           
  Lines       50056    50096   +40     
=======================================
+ Hits        28527    28551   +24     
- Misses      19962    19977   +15     
- Partials     1567     1568    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov enabled auto-merge (squash) August 20, 2024 11:42
@VenelinMartinov VenelinMartinov merged commit 87006ca into master Aug 20, 2024
11 checks passed
@VenelinMartinov VenelinMartinov deleted the vvm/pf_tf_integration_tests branch August 20, 2024 15:05
VenelinMartinov added a commit that referenced this pull request Aug 21, 2024
@VenelinMartinov
PF test defaults and plan modifiers (#2217)
c364b35 
Adds PF integration tests for defaults and plan modifiers.

Regression tests for
#2171 and
#2218

stacked on #2254
@pulumi-bot
Copy link
Contributor

This PR has been shipped in release v3.90.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@corymhall corymhall Awaiting requested review from corymhall

Assignees

@VenelinMartinov VenelinMartinov

Labels
None yet
Projects
None yet
Milestone
0.108
Development

Successfully merging this pull request may close these issues.
4 participants
@VenelinMartinov @pulumi-bot @t0yv0 @mjeffryes