Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v2Resource and v2ResourceMap #2873

Draft
wants to merge 2 commits into
base: implement-shim-resource-for
Choose a base branch
from

Conversation

VenelinMartinov
Copy link
Contributor

No description provided.

@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_resource_and_resource_map branch from 8947c33 to 0f9752d Compare January 28, 2025 14:12
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 84.37500% with 5 lines in your changes missing coverage. Please review.

Project coverage is 67.80%. Comparing base (2513b14) to head (73d9a82).

Files with missing lines Patch % Lines
pkg/tfshim/sdk-v2/provider2.go 83.87% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           implement-shim-resource-for    #2873      +/-   ##
===============================================================
+ Coverage                        67.74%   67.80%   +0.06%     
===============================================================
  Files                              326      324       -2     
  Lines                            41587    41466     -121     
===============================================================
- Hits                             28173    28118      -55     
+ Misses                           11828    11765      -63     
+ Partials                          1586     1583       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_resource_and_resource_map branch 3 times, most recently from 96fc258 to f1f7af1 Compare January 28, 2025 15:27
@VenelinMartinov VenelinMartinov force-pushed the vvm/remove_v2_resource_and_resource_map branch from f1f7af1 to 73d9a82 Compare January 28, 2025 15:34
@VenelinMartinov VenelinMartinov marked this pull request as draft January 28, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant