Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only merge when told #16

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Only merge when told #16

merged 1 commit into from
Oct 9, 2023

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Oct 9, 2023

We are seeing provider's merge without review or release. I believe it is because
automerge is set to "false", which is truthy.

GitHub Actions don't mention a type field for composite action's inputs, which makes me
afraid this is just a string. This is substantiated by actions/runner#2238.

@iwahbe iwahbe requested a review from a team October 9, 2023 16:57
We are seeing provider's merge without review or release. I believe it is because
`automerge` is set to `"false"`, which is truthy.
@iwahbe iwahbe force-pushed the iwahbe/only-merge-when-required branch from 0554827 to 505e393 Compare October 9, 2023 16:58
@iwahbe iwahbe merged commit bc6db05 into main Oct 9, 2023
@iwahbe iwahbe deleted the iwahbe/only-merge-when-required branch October 9, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants