Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commnity): add pulumi-descope to registry #5481

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

omercnet
Copy link
Contributor

@omercnet omercnet commented Sep 23, 2024

Description

Adding a new package?

If this pull request adds a new package:

  • The package's schema URL in this PR is correct.
  • The package metadata file, if present, contains:
    • a supported category (one of Cloud, Infrastructure, Network, Database, Monitoring, or Utility).
    • a valid plugin download URL. See Publish Your Package.
    • a description that explains what the package does.
    • a valid logo URL that points to a PNG whose dimensions conform to the others in this repo (e.g., 100x100).
  • The package repo contains an Overview doc (/docs/_index.md) that includes:
    • a brief explanation of what the package is and what it does.
    • at least one representative example in all supported languages.
    • a front-matter property for the layout set to package.
  • The package repo contains an Installation and Configuration doc (/docs/installation-configuration.md) that includes:
    • links to SDKs in all supported languages.
    • a copyable command for installing the resource plugin if necessary.
    • an example of configuring the provider with pulumi config set.
    • an example of configuring the provider with environment variables.
  • The repository has:
    • a version tag prefixed with v that corresponds with a valid GitHub release and published package SDKs
  • A CODEOWNER has reviewed the PR.
  • A member of the @pulumi/docs team has reviewed all documentation.

Copy link
Member

@ringods ringods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@omercnet can you also add a short Go and .NET example to docs/_index.md?

I also noticed that your latest published version is v0.0.3, but the version of your last Nuget package is still 0.0.2

https://www.nuget.org/packages/Descope.Pulumi.Descope

Did something go wrong while publishing the last release?

@omercnet
Copy link
Contributor Author

hi @ringods - pulumi/pulumi-package-publisher#42 should fix the dotnet publishing issue

@omercnet
Copy link
Contributor Author

omercnet commented Sep 27, 2024

added go, dotnet and yaml - descope/pulumi-descope#46
would that work?

let me know if I should publish a new release for the registry to pick it up

@ringods
Copy link
Member

ringods commented Sep 27, 2024

@omercnet PR with the additional examples approved. After merging, do indeed create a new release. Our registry publishing process only picks up tagged content.

Please also rebase this PR. Since you opened this PR, another provider was already accepted leading to a merge conflict on this same file.

@omercnet
Copy link
Contributor Author

great, will wait for pulumi/pulumi-package-publisher#42 to merge so I can also publish dotnet - will ping you when ready

thanks!

@omercnet
Copy link
Contributor Author

hi @ringods ready for review!

Copy link
Member

@sean1588 sean1588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @omercnet for the contribution and @ringods for reviewing. This all looks good to me. Going to ship it and get it published!

@sean1588 sean1588 merged commit ae46fdc into pulumi:master Oct 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants