Enable gci linter with automatic fix. Apply lint fixes. #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iwahbe
reviewed
Jan 8, 2024
Makefile
Outdated
| @@ -11,7 +11,7 @@ install: | |||
| go install github.com/pulumi/upgrade-provider | |||
|
|
|||
| lint: | |||
| golangci-lint run | |||
| golangci-lint run -E gci --fix | |||
There was a problem hiding this comment.
My prior is that make lint shouldn't make code changes. Instead changes should be delegated to another command, such as make lint.fix.
-E -> --enable because I didn't know what -E meant, but --enable is readable.
Suggested change
| golangci-lint run -E gci --fix | |
| golangci-lint run --enable gci |
There was a problem hiding this comment.
Yeah, that's totally fair - I think a good state is where we can run make lint and see necessary changes.
|
Do we have these standards documented somewhere? I looked into it and we can definitely configure custom rules. |
Not that I'm aware of. I see two patterns in our code bases:
I'm fine with either. |
This change adds linting for Go import sections following current practices in our repositories of grouping by the following custom order: - standard library - blank imports - default imports - imports for Pulumi libraries - local package imports
guineveresaenger
added a commit
to pulumi/pulumi-aiven
that referenced
this pull request
Jan 14, 2024
This PR is part of a migration to standardize the order and grouping of our Go imports. See pulumi/upgrade-provider#236.
guineveresaenger
added a commit
to pulumi/pulumi-akamai
that referenced
this pull request
Jan 16, 2024
This PR is part of a migration to standardize the order and grouping of our Go imports. See pulumi/upgrade-provider#236.
guineveresaenger
added a commit
to pulumi/pulumi-alicloud
that referenced
this pull request
Jan 16, 2024
This PR is part of a migration to standardize the order and grouping of our Go imports. See pulumi/upgrade-provider#236.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we want to standardize import grouping and sorting, we should enforce it in code.