-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release instructions for Homebrew to README.md #221
Conversation
Gotta love it. Appears the TravisCI linux build is failing while trying to Looks like this has been broken on master since https://travis-ci.org/puma/puma-dev/builds/609699900?utm_source=github_status&utm_medium=notification but that commit only changed |
@@ -1,3 +1,5 @@ | |||
// +build darwin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file has no business being part of the linux build. it uses launch_activate_socket
which is only provided on macOS.
I'm unsure as to why travis picks up this file as part of go get
but all attempts to replicate locally on linux don't run into the same problem. perhaps there's some greedy compilation configured somewhere?
regardless, this functionality is irrelevant on linux, so it seems safe to isolate this file to builds on darwin arch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nateberkopec let me know if you'd prefer that i pr this fix separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(for posterity; see also #225)
😍 Gorgeous! |
This PR adds instructions for manually authoring a new package suitable for release via a Homebrew formula. Ideally, all of this would be handled by TravisCI, but #babysteps. In order to support artifact upload via
ghr
, this PR also modifiesmake release
to drop binaries into a single directory./pkg
.I've make an example of a release created with these instructions.
Last Homebrew release of
puma-dev
was on Aug 21, 2018. There have been a few updates since then that seem to fix issues for folks.