Fixes mozilla-services#4667 - Add alt text to images on shot and mysh…

…ots page
punamdahiya · Dec 18, 2018 · 3432e89 · 3432e89
1 parent dcd93a2
commit 3432e89
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/server/src/delete-shot-button.js b/server/src/delete-shot-button.js
@@ -93,7 +93,7 @@ exports.DeleteShotButton = class DeleteShotButton extends React.Component {
             title="Delete this shot permanently"
             onClick={this.onClickDelete.bind(this)}
             ref={this.trashButtonRef}>
-            <img src={this.props.staticLink("/static/img/icon-trash.svg")} />
+            <img alt="" src={this.props.staticLink("/static/img/icon-trash.svg")} />
           </button>
         </Localized>
         { confirmationPanel }

diff --git a/server/src/pages/shot/shotpage-header.js b/server/src/pages/shot/shotpage-header.js
@@ -33,7 +33,7 @@ exports.ShotPageHeader = class ShotPageHeader extends React.Component {
     return (
       <Localized id="shotPageAllShotsButton" attrs={{title: true}}>
         <a className="nav-button icon-shots" href="/shots" tabIndex="0" title="All Shots">
-          <img src={this.props.staticLink("/static/img/icon-shots.svg")} />
+          <img alt="" src={this.props.staticLink("/static/img/icon-shots.svg")} />
         </a>
       </Localized>
     );

diff --git a/server/src/pages/shot/view.js b/server/src/pages/shot/view.js
@@ -368,7 +368,7 @@ class Body extends React.Component {
       <Localized id="shotPageDownloadShot" attrs={{title: true}}>
         <button className={`button transparent nav-button`} onClick={this.onClickDownload.bind(this)}
                 title="Download the shot image">
-          <img src={this.props.staticLink("/static/img/icon-download.svg")} />
+          <img alt="" src={this.props.staticLink("/static/img/icon-download.svg")} />
         </button>
       </Localized></div>;
 
@@ -387,7 +387,7 @@ class Body extends React.Component {
         <Localized id="shotPagefavoriteButton" attrs={{title: true}}>
           <button className={`button transparent nav-button ${inactive}`}
                   disabled={!this.props.hasFxa} onClick={this.onClickFavorite.bind(this)}>
-            <img src={favImgSrc} />
+            <img alt="" src={favImgSrc} />
           </button>
         </Localized></div>;
 
@@ -406,7 +406,7 @@ class Body extends React.Component {
                     title="Edit this image"
                     onClick={this.onClickEdit.bind(this)}
                     ref={(edit) => { this.editButton = edit; }}>
-              <img src={this.props.staticLink("/static/img/icon-pen.svg")} />
+              <img alt="" src={this.props.staticLink("/static/img/icon-pen.svg")} />
             </button>
           </Localized>
           <PromoDialog promoClose={this.promoClose.bind(this)} display={this.state.promoDialog} />
@@ -419,7 +419,7 @@ class Body extends React.Component {
           <button className="button nav-button transparent copy"
                   title="Copy image to clipboard"
                   onClick={this.onClickCopy.bind(this)}>
-            <img src={this.props.staticLink("/static/img/icon-copy.svg")} />
+            <img alt="" src={this.props.staticLink("/static/img/icon-copy.svg")} />
           </button>
         </Localized></div>;
     }

diff --git a/server/src/pages/shotindex/view.js b/server/src/pages/shotindex/view.js
@@ -367,7 +367,7 @@ class Card extends React.Component {
         key={shot.id}>
         <a href={shot.viewUrl} onClick={this.onOpen.bind(this, shot.viewUrl)}>
           <div className="shot-image-container">
-            <img src={imageUrl} />
+            <img alt="" src={imageUrl} />
           </div>
           <div className="shot-info">
           <div className="title-container">