Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use units everywhere! #144

Merged
merged 7 commits into from
Aug 6, 2024
Merged

Use units everywhere! #144

merged 7 commits into from
Aug 6, 2024

Conversation

jmbhughes
Copy link
Member

@jmbhughes jmbhughes commented Aug 2, 2024

PR summary

Uses units as extensively as possible

Todos

  • clean up some of the transforms (delayed for another PR)
  • improve test coverage (it's good enough)
  • Remove CI for Python 3.10
  • Update documentation and example notebook
  • Check the polar keyword is set when starting resolve (delayed until another PR)
  • Check the polar keyword is always as expected when starting a transform (delayed for another PR)
  • Fix development instructions
  • Update README to note new features
  • Make a transform decorator to check NDCollection keys for proper inputs (and outputs?)

Test plan

Watch CI pass

Breaking changes

  • Keys have all changed.
  • Bumps min Python version.

Related Issues

Resolves #139

@jmbhughes jmbhughes self-assigned this Aug 2, 2024
Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 91.75258% with 32 lines in your changes missing coverage. Please review.

Project coverage is 92.16%. Comparing base (d809388) to head (324f198).
Report is 4 commits behind head on main.

Files Patch % Lines
solpolpy/core.py 83.87% 10 Missing ⚠️
solpolpy/instruments.py 58.33% 10 Missing ⚠️
solpolpy/plotting.py 70.00% 6 Missing ⚠️
solpolpy/transforms.py 97.70% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   92.93%   92.16%   -0.77%     
==========================================
  Files           9        9              
  Lines         538      549      +11     
==========================================
+ Hits          500      506       +6     
- Misses         38       43       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmbhughes jmbhughes merged commit 8ad944f into main Aug 6, 2024
5 checks passed
@jmbhughes jmbhughes deleted the use-units branch August 6, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use astropy units more completely
1 participant