Skip to content

Commit

Permalink
Exclude shaded variant of Kotlin's ModuleDescriptorImpl
Browse files Browse the repository at this point in the history
Issue #146 identified a quasar instrumentation problem that causes a
`VerifyError` in Kotlin's `ModuleDescriptorImpl`. The fix for #146
explicitly excludes this class by its fully qualified name
`kotlin.reflect.jvm.internal.impl.descriptors.impl.ModuleDescriptorImpl`,
and this works, but this same class is shaded/repackaged as
`org.jetbrains.kotlin.descriptors.impl.ModuleDescriptorImpl` within the
kotlin-compiler[-embeddable] jars.

This fix adds the latter to the set of exclusions so the workaround
applies to both cases.
  • Loading branch information
cbeams committed Apr 12, 2016
1 parent 5110743 commit 14d7f2f
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ private static String[] sa(String... elems) {
// Class prefixes that are known not to suspend
excludePrefixes = new String[] {
// TODO: this specifically is also known to cause a `VerifyError` when instrumented, see #146
"kotlin/reflect/jvm/internal/impl/descriptors/impl/ModuleDescriptorImpl"
"kotlin/reflect/jvm/internal/impl/descriptors/impl/ModuleDescriptorImpl",
// Handle the same class, when shaded within kotlin-compiler[-embeddable]
"org/jetbrains/kotlin/descriptors/impl/ModuleDescriptorImpl"
};
}

Expand Down

0 comments on commit 14d7f2f

Please sign in to comment.