Add transport for FreeBSD jails #3170
Conversation
!feature * **Add transport for FreeBSD jails** ([puppetlabs#3160](puppetlabs#3170)) FreeBSD has support for jails since FreeBSD 4.0 (released in 2000). Add a new 'jail' transport to Bolt to allow management of jails on FreeBSD.
smortex
force-pushed
the
jail-transport
branch
3 times, most recently
from
ec11acb
to
50619e7
Compare
!feature * **Add transport for FreeBSD jails** ([puppetlabs#3160](puppetlabs#3170)) FreeBSD has support for jails since FreeBSD 4.0 (released in 2000). Add a new 'jail' transport to Bolt to allow management of jails on FreeBSD.
smortex
force-pushed
the
jail-transport
branch
from
d8fea6c
to
8803813
Compare
!feature * **Add transport for FreeBSD jails** ([puppetlabs#3160](puppetlabs#3170)) FreeBSD has support for jails since FreeBSD 4.0 (released in 2000). Add a new 'jail' transport to Bolt to allow management of jails on FreeBSD.
smortex
force-pushed
the
jail-transport
branch
from
8803813
to
ae51234
Compare
!feature * **Add transport for FreeBSD jails** ([puppetlabs#3160](puppetlabs#3170)) FreeBSD has support for jails since FreeBSD 4.0 (released in 2000). Add a new 'jail' transport to Bolt to allow management of jails on FreeBSD.
smortex
force-pushed
the
jail-transport
branch
3 times, most recently
from
8de7efe
to
06b7c3c
Compare
|
Now that the CI is fixed, I rebased on top of the main branch and added a commit to fix the relevant CI failures (you can't run acceptance tests on a non-FreeBSD node). This is now ready for review, thanks! |
There was a problem hiding this comment.
I think the code looks good. Can we start this transport off as an experimental feature (like the podman transport? https://github.com/puppetlabs/bolt/blob/main/documentation/experimental_features.md#podman-support ) I think that would just include a quick description of the transport in experimental_features.md and a note in the commit message that is used to generate the release note c1c7c4e about the feature being experimental.
!feature * **Add transport for FreeBSD jails** ([puppetlabs#3160](puppetlabs#3170)) FreeBSD has support for jails since FreeBSD 4.0 (released in 2000). Add a new 'jail' transport to Bolt to allow management of jails on FreeBSD. This feature is currently considered experimental.
|
Nice! I added a section to the doc, this allowed me to spot that I should remove Because I had to amend my old commit, I rebased on top of master and squashed the fixes to their respective commit. |
|
Thanks, trying to fix up that modules test in #3194 . it is unrelated to your PR. |
|
💯 I am keeping on this PR and will rebase on top of it when it is ready! Thanks! |
!feature * **Add transport for FreeBSD jails** ([puppetlabs#3160](puppetlabs#3170)) FreeBSD has support for jails since FreeBSD 4.0 (released in 2000). Add a new 'jail' transport to Bolt to allow management of jails on FreeBSD. This feature is currently considered experimental.
This require a jail named `bolt` where python3.9 is installed.
|
Looks good! For the sake of safety, I switched the PR to draft because I did some changes that should not change anything, but I have no access to my FreeBSD work station ATM to be 100% sure I did not messed something while doing it. |
|
I just checked that the inventory sample using a structure I am not used to and I copied from another example is working as expected (it is 😉)! Ready for final reviews! |
|
Thanks! We are having some infra issues currently that is preventing me from getting this merged and released. We are working through that and I will merge this ASAP. |
FreeBSD has support for jails since FreeBSD 4.0 (released in 2000).
Add a new 'jail' transport to Bolt to allow management of jails on FreeBSD.
Also add integration tests for jail transport. This require a jail named
boltwhere python3.9 is installed.While here, use
/bin/shwhen only a basic shell is required and avoid depending onbashor "bashisms" (code that is not portable and only works in bash) for the code used for FreeBSD jails.