-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(RE-9326) update_yum_repo should automatically overwrite repodata when updating #109
Conversation
Tested by running |
@@ -58,7 +58,7 @@ yum_repo_command: | | |||
sudo chown -R root:release "${repodir}/repodata" ; | |||
sudo chmod -R g+w "${repodir}/repodata" ; | |||
createrepo --checksum=sha --database --update "${repodir}" ; | |||
gpg --use-agent --armor --detach-sign -u __GPG_KEY__ "${repodir}/repodata/repomd.xml" ; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How come specifying --yes
and --use-agent
broke? I don't see anything in the documentation that suggests they wouldn't work together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly have no idea, but when I had them together, I got this error:
gpg: skipped "--yes": secret key not available
gpg: signing failed: secret key not available
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This led me to try removing --use-agent
: IJHack/QtPass#92 (comment)
According to https://www.gnupg.org/documentation/manuals/gnupg/GPG-Configuration-Options.html, |
…n updating This commit adds the `--yes` option to the gpg command so that the person shipping doesn't have to manually type 'yes' for overwriting. In order for this to work, I had to stop using tty.
@demophoon I was able to get |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge first thing in the morning
CLA signed by all contributors. |
This commit adds the
--yes
option to the gpg command so that the person shipping doesn't have to manually type 'yes' for overwriting. In order for this to work, I had to remove--use-agent
, but it seems that the use of keychain makes that option irrelevant anyway.