(PA-2055) Disable warnings for boost::variant #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branan
reviewed
Jul 17, 2018
lib/inc/hocon/types.hpp
Outdated
| @@ -3,7 +3,15 @@ | |||
| #include <memory> | |||
| #include <vector> | |||
| #include <unordered_map> | |||
| #pragma GCC diagnostic push | |||
| #pragma GCC diagnostic ignored "-Waddress" | |||
| #ifdef __GNUC__ | |||
There was a problem hiding this comment.
I believe that this can be collapsed as #if defined(__GNUC__) && __GNUC__ > 5
With boost 1.67, boost/variant.hpp introduces address and (in gcc 6+) nonnull-compare warnings; Quiet these to allow successful builds with -Werror.
caseywilliams
force-pushed
the
PA-2055/boost-167
branch
from
b1be96b to
1841202
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With boost 1.67, boost/variant.hpp introduces address and (in gcc 6+)
nonnull-compare warnings; Quiet these to allow successful builds with
-Werror. This supports puppetlabs/puppet-agent#1482.