(FACT-2815) Added timing for cached facts #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA signed by all contributors. |
| .and_return(cached_external_fact) | ||
| allow(File).to receive(:mtime).with(File.join(cache_dir, 'ext_file.txt')).and_return(Time.now) | ||
|
|
||
| cache_manager.resolve_facts(searched_facts) |
There was a problem hiding this comment.
You could add an empty line to make the separation between the Arrange, Act and Assertion parts of the unit test.
| if Options[:timing] | ||
| time = Benchmark.measure { yield } | ||
|
|
||
| puts "fact `#{fact_name}`, took: #{time.format('%r')} seconds" | ||
| log = "fact '#{fact_name}', took: #{time.format('%r')} seconds" | ||
| puts "#{prefix_message} #{log}" |
There was a problem hiding this comment.
You could check if the prefix_message is not empty and a space after it. This way, you'll avoid offsetting the log message with a space
|
Does this PR resolve the inconsistent timing issue of cached facts? |
sebastian-miclea
force-pushed
the
FACT-2815
branch
from
509bf1e
to
d634ac6
Compare
BogdanIrimie
approved these changes
Oct 19, 2020
|
Filipovici-Andrei
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated --timing option to also show time needed to read from cached. Before, cached facts were skipped.