(FACT-3114) Arch Linux: Implement os version facts

[bastelfreak]

From this branch:

$ bundle exec facter os
{
  architecture => "x86_64",
  distro => {
    codename => "n/a",
    description => "Arch Linux",
    id => "Arch",
    release => {
      full => "rolling",
      major => "rolling",
      minor => null
    },
    specification => "n/a"
  },
  family => "Archlinux",
  hardware => "x86_64",
  name => "Archlinux",
  release => {
    full => "6.9.3-arch1-1",
    major => "6",
    minor => "9"
  },
  selinux => {
    enabled => false
  }
}

Facter 3 on Archlinux:

$ facter os
{
  architecture => "x86_64",
  distro => {
    codename => "n/a",
    description => "Arch Linux",
    id => "Arch",
    release => {
      full => "rolling",
      major => "rolling"
    },
    specification => "n/a"
  },
  family => "Archlinux",
  hardware => "x86_64",
  name => "Archlinux",
  release => {
    full => "6.9.3-arch1-1",
    major => "6",
    minor => "9"
  },
  selinux => {
    enabled => false
  }
}

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[bastelfreak]

please provide some feedback. I'm not sure how to write spec tests for this and I haven't tested this yet on Arch Linux.

[joshcooper]

Facter 4 makes some assumptions that the ID from /etc/os-release maps to the Facter::<ID>::Os::Resolver class, for example. So you'll want to rename your file to lib/facter/facts/arch/os/release.rb and then its call_the_resolver method will automagically be called.

Your implementation will then need to query (something?) to get the OS version.

You may also want to update the fact OS hierarchy code in

facter/lib/facter/config.rb

Line 6 in e5ad338

OS_HIERARCHY = [

to ensure that osfamily is consistent across facter 3 and 4

[CLAassistant]

All committers have signed the CLA.

[joshcooper]

Hi @bastelfreak please see my last comments about next steps, thanks!

[bastelfreak]

thanks for merging!