Windows: Add is_virtual and virtual support for virtual machines hosted on Nutanix AHV
#2692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
…x AHV
Prior to this change facter returned:
$ facter is_virtual
false
$ facter virtual
physical
After this change facter returns:
$ facter is_virtual
true
$ facter virtual
ahv
Systems running on Nutanix AHV are correctly recognized now.
This formatting style makes the hash easier to read, and makes diffs smaller.
This adds a test for commit 677ff09.
joshcooper
approved these changes
Apr 11, 2024
|
Marking this as a bug since it used to work in facter 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just adds a test to #2589 and is rebased on current
main.