(FACT-3463) Add server to mountpoint device for AIX #2734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have manually checked this change in |
joshcooper
reviewed
Jun 18, 2024
| device = "#{server}:#{elem[0]}" | ||
| else | ||
| device = elem[0] | ||
| end |
There was a problem hiding this comment.
Ah interesting, there was a previous fix 6c6ef2d to just ignore the server. Could you mention that in your commit message?
joshcooper
approved these changes
Jun 18, 2024
Previously, in 6c6ef2d, facter omitted the server from the mountpoint data on AIX; this makes it inconsistent with the mountpoints that facter reports in various other linux flavors. This commit adds it back to the `device` key for AIX mountpoints.
tvpartytonight
force-pushed
the
FACT-3463
branch
from
a190757
to
5b711a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.