Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provider updates #66

Merged
merged 7 commits into from
May 11, 2023
Merged

Provider updates #66

merged 7 commits into from
May 11, 2023

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Feb 8, 2023

  • update pdk
  • lint housekeeping
  • add detail to api call errors
  • provider simple_get_filter support
  • add admin_token support to retrieve_token function
  • extend influxdb_auth, support specifying permission resource user, org, and (type) name
  • extend influxdb_auth with force parameter to recreate permission

@h0tw1r3 h0tw1r3 requested a review from a team as a code owner February 8, 2023 21:15
@puppet-community-rangefinder
Copy link

influxdb::retrieve_token is a function

that may have no external impact to Forge modules.

influxdb_auth is a type

Breaking changes to this file WILL impact these 1 modules (exact match):

influxdb_bucket is a type

Breaking changes to this file WILL impact these 1 modules (exact match):

influxdb_dbrp is a type

that may have no external impact to Forge modules.

influxdb_label is a type

that may have no external impact to Forge modules.

influxdb_org is a type

Breaking changes to this file WILL impact these 1 modules (exact match):

influxdb_user is a type

Breaking changes to this file MAY impact these 1 modules (near match):

influxdb is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

influxdb::profile::toml is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 0 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@m0dular
Copy link
Contributor

m0dular commented Feb 8, 2023

Thanks for the PR! We should be merging #65 soon, so we'll need to rebase this at some point to account for those changes. The main thing is that influx_get() will return an array of responses to account for the pagination. I also added some better error handling (that should have always been there), so between that and the better API responses in your PR the error handling should be much better.

I'm interested to see the effects of the simple_get_filter. I did notice in testing #65 that it was calling get() for every declared resource and that we were hitting the API way more than needed because of that, following the links for everything, and updating the caches for every resource. I changed it to only create the cache once per resource, so I think these changes will make the performance better.

@MartyEwings
Copy link
Contributor

@h0tw1r3 sorry for the delay, would you mind rebasing over the current changes and we will look into merging this

@MartyEwings MartyEwings added the enhancement New feature or request label Apr 18, 2023
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@h0tw1r3 h0tw1r3 force-pushed the provider-updates branch 2 times, most recently from a763186 to 7a48d3f Compare April 25, 2023 06:13
@h0tw1r3
Copy link
Contributor Author

h0tw1r3 commented May 9, 2023

@MartyEwings @m0dular rebased, SLES test failures seem unrelated to changes.

@h0tw1r3 h0tw1r3 force-pushed the provider-updates branch from 7a48d3f to 24a4af8 Compare May 10, 2023 18:32
@h0tw1r3 h0tw1r3 requested a review from m0dular May 10, 2023 18:35
Copy link
Contributor

@m0dular m0dular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@m0dular m0dular merged commit 9d24cab into puppetlabs:main May 11, 2023
@h0tw1r3 h0tw1r3 deleted the provider-updates branch May 11, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants