Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Dependencies) - Upgrade puppet-lint to v4.2.4 & puppet-strings to v4.1.2 #370

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

jordanbreen28
Copy link
Contributor

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 added the enhancement New feature or request label Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (67257c0) 11.69% compared to head (eda87a9) 11.69%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #370   +/-   ##
=======================================
  Coverage   11.69%   11.69%           
=======================================
  Files          92       92           
  Lines       11499    11499           
=======================================
  Hits         1345     1345           
  Misses      10154    10154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 marked this pull request as ready for review February 9, 2024 11:48
@jordanbreen28 jordanbreen28 requested a review from a team as a code owner February 9, 2024 11:48
@jordanbreen28 jordanbreen28 added enhancement New feature or request Language Server bugfix and removed enhancement New feature or request labels Feb 9, 2024
Copy link
Contributor

@LukasAud LukasAud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LukasAud LukasAud merged commit 37693a2 into main Feb 14, 2024
19 of 21 checks passed
@LukasAud LukasAud deleted the maint-upgrade_puppet-lint branch February 14, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants