(bug) - Add synchronization to Dir.chdir in init_puppet_lint #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit wraps the `Dir.chdir` call in the `validation_provider.rb` file within a `$PuppetParserMutex.synchronize` block. Before this change, the `Dir.chdir` method was called without synchronization, which could lead to conflicts if another `chdir` block was in progress. This change prevents the error "(puppet/fixDiagnosticErrors) conflicting chdir during another chdir block" by ensuring that the `Dir.chdir` call is only executed by one thread at a time.
jordanbreen28
force-pushed
the
bug-add_sync_to_puppet-lint-init
branch
from
6045797 to
fb4bc1d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
==========================================
- Coverage 11.69% 11.69% -0.01%
==========================================
Files 92 92
Lines 11499 11501 +2
==========================================
Hits 1345 1345
- Misses 10154 10156 +2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR wraps the
Dir.chdircall in thevalidation_provider.rbfile within a$PuppetParserMutex.synchronizeblock.Before this change, the
Dir.chdirmethod was called without synchronization, which could lead to conflicts if anotherchdirblock was in progress.This change prevents the error "(puppet/fixDiagnosticErrors) conflicting chdir during another chdir block" by ensuring that the
Dir.chdircall is only executed by one thread at a time.Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist