(CONT-339) Update CI for ruby 2.5 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
changed the title
bastelfreak
reviewed
Feb 23, 2023
chelnak
force-pushed
the
CONT-339-update_ci_for_multiple_rubies
branch
from
d79ef2d to
19fc600
Compare
chelnak
force-pushed
the
CONT-339-update_ci_for_multiple_rubies
branch
from
19fc600 to
50b76b3
Compare
jordanbreen28
approved these changes
Feb 23, 2023
|
The whole issue with this is that it pulls in puppetlabs_spec_helper, which is done for acceptance tests. However, it creates a circular dependency. IMHO it must be removed. If you want to do real testing, use something that doesn't need a whole VM. This is just a gem and you control the environment, so you can consider a framework like cucumber. I see this was already merged while I was writing #89 but please consider to get rid of Litmus here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.