(CONT-675) Fix fact detection #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chelnak
force-pushed
the
CONT-675-fix_fact_detection
branch
from
9e304eb to
05aa8f6
Compare
chelnak
force-pushed
the
CONT-675-fix_fact_detection
branch
from
05aa8f6 to
e3815ce
Compare
bastelfreak
reviewed
Feb 28, 2023
| end | ||
|
|
||
| it 'uses the facts hash' do | ||
| expect(manifest).to eq("$facts['os']['family']") |
There was a problem hiding this comment.
in the future we should consider reworking the legacy_fact/topscope_fact/topscope_variable check because they heavily overlap.
There was a problem hiding this comment.
would it make sense to add some tests from https://github.com/puppetlabs/puppet-lint/blob/e3815cebdfa50100acb888e29fde8f03f4e1879b/spec/unit/puppet-lint/plugins/top_scope_facts/top_scope_facts_spec.rb here? But expect no changes? I want to prevent that legacy_fact and topscope_fact fix the same code.
There was a problem hiding this comment.
I was looking in to this yesterday. It would seem that they no longer clash but adding extra tests is never a bad thing.
Prior to this change the legacy facts check would not detect legacy facts defined as follows: ``` $::facts['osfamily'] ```` This changes updates the `check` logic to evaluate tokens that may start with `::` and extract the fact name as appropriate. `
chelnak
force-pushed
the
CONT-675-fix_fact_detection
branch
from
e3815ce to
a3b7241
Compare
bastelfreak
approved these changes
Feb 28, 2023
GSPatton
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the legacy facts check would not detect legacy facts defined as follows:
This changes updates the
checklogic to evaluate tokens that may start with::and extract the fact name as appropriate. `