Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-1265) - Fix agent install on vagrant boxes #518

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

jordanbreen28
Copy link
Contributor

Summary

This PR fixes an issue where the puppet agent binary was not present on the secure path of the vagrant boxes, so subsequent puppet operations would fail.

It utilises the already present provision::fix_secure_path task in order to make the puppet agent binary accessible to all sudo users on the box, in most cases vagrant.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Fixes puppetlabs/provision#225

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

@jordanbreen28 jordanbreen28 requested a review from a team as a code owner July 31, 2023 09:41
@jordanbreen28 jordanbreen28 force-pushed the CAT-1265-Fix_agent_install_on_vagrant branch 3 times, most recently from 2e1f305 to ed44f8b Compare July 31, 2023 09:45
This commit fixes an issue where the puppet agent binary was not present
on the secure path of the vagrant boxes, so subsequent puppet operations
would fail.

It utilises the already present provision::fix_secure_path task in order
to make the puppet agent binary accessible to all sudo users on the box,
in most cases vagrant.
@jordanbreen28 jordanbreen28 force-pushed the CAT-1265-Fix_agent_install_on_vagrant branch from ed44f8b to 4b089d2 Compare July 31, 2023 09:46
@GSPatton GSPatton merged commit ae9887f into main Jul 31, 2023
2 checks passed
@GSPatton GSPatton deleted the CAT-1265-Fix_agent_install_on_vagrant branch July 31, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install_agent task doesn't work on some OS versions
2 participants