Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add supported docker el9 platforms to matrix #551

Merged
merged 1 commit into from
May 1, 2024

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Apr 13, 2024

No description provided.

@h0tw1r3 h0tw1r3 requested a review from a team as a code owner April 13, 2024 01:36
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.04%. Comparing base (43df54f) to head (64b78cc).

❗ Current head 64b78cc differs from pull request most recent head 2ea325c. Consider uploading reports for the commit 2ea325c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   63.95%   63.04%   -0.92%     
==========================================
  Files           6        6              
  Lines         763      763              
==========================================
- Hits          488      481       -7     
- Misses        275      282       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david22swan
Copy link
Member

@h0tw1r3 Removal's and additions should be contained within separate PRs for tracking purposes

@h0tw1r3 h0tw1r3 changed the title Update Matrix Docker platforms add supported docker el9 platforms to matrix Apr 26, 2024
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @h0tw1r3, could you update the spec tests? Our silent failures have caused a knock-on effect with your PRs, so apologies

@h0tw1r3 h0tw1r3 force-pushed the meta-os branch 2 times, most recently from 44262ce to 2ea325c Compare April 30, 2024 17:06
@jordanbreen28 jordanbreen28 merged commit 0de4b09 into puppetlabs:main May 1, 2024
6 checks passed
@h0tw1r3 h0tw1r3 deleted the meta-os branch May 7, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants