Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass full inventory path to task #552

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

h0tw1r3
Copy link
Contributor

@h0tw1r3 h0tw1r3 commented Apr 24, 2024

As mentioned in puppetlabs/provision#259, the provision task inventory parameter is documented to be the full path to a bolt inventory file.

This PR moves the spec/fixtures/litmus_inventory.yaml inventory path assumption from the provision module, to here (where it should be).

this is the beginning of uncoupling the litmus specific assumptions in the provision module.

@h0tw1r3 h0tw1r3 requested a review from a team as a code owner April 24, 2024 04:35
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.95%. Comparing base (43df54f) to head (5ab6061).

❗ Current head 5ab6061 differs from pull request most recent head d4739b3. Consider uploading reports for the commit d4739b3 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #552   +/-   ##
=======================================
  Coverage   63.95%   63.95%           
=======================================
  Files           6        6           
  Lines         763      763           
=======================================
  Hits          488      488           
  Misses        275      275           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@h0tw1r3 h0tw1r3 marked this pull request as draft April 30, 2024 16:07
@h0tw1r3 h0tw1r3 force-pushed the inventory branch 4 times, most recently from 4eb529c to a591bc2 Compare April 30, 2024 16:57
@h0tw1r3 h0tw1r3 changed the title (maint) pass full inventory path to task pass full inventory path to task Apr 30, 2024
@h0tw1r3 h0tw1r3 force-pushed the inventory branch 2 times, most recently from 5ab6061 to d4739b3 Compare April 30, 2024 17:05
@h0tw1r3 h0tw1r3 marked this pull request as ready for review July 9, 2024 08:46
@jordanbreen28 jordanbreen28 merged commit dc6cefe into puppetlabs:main Jul 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants