Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Port numbers for monitored services monitored by should be configurable #48

Closed
Sharpie opened this issue Apr 11, 2019 · 1 comment · Fixed by #50
Closed

Port numbers for monitored services monitored by should be configurable #48

Sharpie opened this issue Apr 11, 2019 · 1 comment · Fixed by #50
Labels
enhancement New feature or request

Comments

@Sharpie
Copy link
Member

Sharpie commented Apr 11, 2019

The telegraf.conf.epp template currently hardcodes the ports that it uses to collect data from monitored services, 8140, 8081. The Postgres collection also omits the port number, which is an equivalent to harcoding 5432.

PuppetDB commonly has to run on a different port as 8081 conflicts with several monitoring and anti-virus products. We should make the port numbers configurable.
@Sharpie Sharpie added the enhancement New feature or request label Apr 11, 2019
@Sharpie
Copy link
Member Author

Sharpie commented Apr 23, 2019

I'm thinking the easiest way to implement this would be to change the dataype of the host lists from Array[String] to Array[Variant[String, Tuple[String, Integer]]. Then for each entry of the list:

  • If String, it's only a hostname and the default port for the service should be used.
  • If Tuple[String, Integer], then it's a pair of hostname and port.

Sharpie added a commit to Sharpie/puppet_metrics_dashboard that referenced this issue Apr 25, 2019
@Sharpie
Allow port numbers of services to be specified
a986a13 
This commit updates the master_list, puppetdb_list, and postgres_host_list
parameters to allow pairs of `[hostname, port number]` in addition to just
a hostname. If the port number is specified, then Telegraf will be configured
to use that port when requesting metrics from the host. If no port number is
specified, then Telegraf will be configured to use the default prts of
8140 for Puppet Server, 8081 for PuppetDB, and 5432 for Postgres.

Closes puppetlabs#48
Sharpie added a commit to Sharpie/puppet_metrics_dashboard that referenced this issue Apr 25, 2019
@Sharpie
Allow port numbers of services to be specified
7038f8e 
This commit updates the master_list, puppetdb_list, and postgres_host_list
parameters to allow pairs of `[hostname, port_number]` in addition to just
a hostname. If the port number is specified, then Telegraf will be configured
to use that port when requesting metrics from the host. If no port number is
specified, then Telegraf will be configured to use the default prts of
8140 for Puppet Server, 8081 for PuppetDB, and 5432 for Postgres.

Closes puppetlabs#48
Sharpie added a commit to Sharpie/puppet_metrics_dashboard that referenced this issue Apr 25, 2019
@Sharpie
Allow port numbers of services to be specified
473c24b 
This commit updates the master_list, puppetdb_list, and postgres_host_list
parameters to allow pairs of `[hostname, port_number]` in addition to just
a hostname. If the port number is specified, then Telegraf will be configured
to use that port when requesting metrics from the host. If no port number is
specified, then Telegraf will be configured to use the default prts of
8140 for Puppet Server, 8081 for PuppetDB, and 5432 for Postgres.

Closes puppetlabs#48
@Sharpie Sharpie mentioned this issue Apr 25, 2019
Merged
Sharpie added a commit to Sharpie/puppet_metrics_dashboard that referenced this issue Apr 25, 2019
@Sharpie
Allow port numbers of services to be specified
0edf9c6 
This commit updates the master_list, puppetdb_list, and postgres_host_list
parameters to allow pairs of `[hostname, port_number]` in addition to just
a hostname. If the port number is specified, then Telegraf will be configured
to use that port when requesting metrics from the host. If no port number is
specified, then Telegraf will be configured to use the default prts of
8140 for Puppet Server, 8081 for PuppetDB, and 5432 for Postgres.

Closes puppetlabs#48
Sharpie added a commit to Sharpie/puppet_metrics_dashboard that referenced this issue Apr 25, 2019
@Sharpie
Allow port numbers of services to be specified
dba059b 
This commit updates the master_list, puppetdb_list, and postgres_host_list
parameters to allow pairs of `[hostname, port_number]` in addition to just
a hostname. If the port number is specified, then Telegraf will be configured
to use that port when requesting metrics from the host. If no port number is
specified, then Telegraf will be configured to use the default prts of
8140 for Puppet Server, 8081 for PuppetDB, and 5432 for Postgres.

Closes puppetlabs#48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow port numbers of services to be specified Sharpie/puppet_metrics_dashboard
1 participant
@Sharpie