Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

(maint) v2.3.1 release prep #103

Merged
merged 1 commit into from
Aug 11, 2020
Merged

(maint) v2.3.1 release prep #103

merged 1 commit into from
Aug 11, 2020

Conversation

suckatrash
Copy link
Contributor

  • Ran pdk update
  • Ran `pdk bundle exec puppet strings generate --format markdown
  • update Changelog and metadata.json

@suckatrash suckatrash force-pushed the v2_3_1-release_prep branch 4 times, most recently from 5cb37aa to 5fe45c8 Compare July 17, 2020 15:28
@suckatrash suckatrash force-pushed the v2_3_1-release_prep branch 2 times, most recently from 42f6eb7 to 4b03df5 Compare July 24, 2020 18:54
@suckatrash suckatrash force-pushed the v2_3_1-release_prep branch 3 times, most recently from 848b571 to bfba206 Compare July 24, 2020 21:55
jarretlavallee
jarretlavallee suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be good to ship this after reverting the acceptance test changes. The failures are from an upstream component and would happen in any version of this module.

@jarretlavallee
Copy link
Contributor

Kicking CI now that telegraf 1.5.2 has been released with the fix: https://github.com/influxdata/telegraf/blob/master/CHANGELOG.md#v1152-2020-07-31

jarretlavallee
jarretlavallee suggested changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@jarretlavallee jarretlavallee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We just need to bump the version in the metadata.json and add back in the expect(apply_manifest in the acceptance testing.

@suckatrash suckatrash force-pushed the v2_3_1-release_prep branch from bfba206 to f77a7b4 Compare August 11, 2020 15:27
@jarretlavallee
Copy link
Contributor

:shipit:

@jarretlavallee jarretlavallee merged commit 1947285 into master Aug 11, 2020
@jarretlavallee jarretlavallee deleted the v2_3_1-release_prep branch August 11, 2020 15:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jarretlavallee jarretlavallee jarretlavallee approved these changes

@genebean genebean genebean approved these changes

Assignees
No one assigned
Labels
Do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suckatrash @jarretlavallee @genebean