PuppetDB on Compilers

[coreymbe]

Adding role to mitigate CVE-2020-7943 for Compilers running PuppetDB.

[suckatrash]

I wonder if it would be better to update the Readme with this as an example instead of adding another class to the module?

Up until now we've stuck to providing defined types for these kinds of things to allow flexibility around where telegraf runs (several telegraf collectors on a single grafana server vs. telegraf on each Puppet component), and while CVE-2020-7943 forces us to do the latter we still have to support both. I wonder if this addition would confuse things or should really warrant a bigger refactor.

Also I'd like to stay away from the role naming since roles normally meet specific requirements and are more typically written by Puppet Admins at the org. that uses them.

[jarretlavallee]

As @suckatrash mentioned, role naming should be avoided in this case. The main problem that this Jira ticket is trying to solve is that we cannot add a class from the classifier for the profile. So the user is left to write their own class to include the defined types. Adding a class somewhere that enables the user to add the profile into the classification in the console would be ideal.

Some of the profiles are defined types and others are classes. We could potentially put this as a class in a similar naming scheme as puppet_metrics_dashboard::profile::master::install where the install is the class that includes the defined types.

[suckatrash]

Looks good! Can we add a note in the changelog? (you can make a new release entry with date / version as TBD).

## Date TBD - Release - 2.3.x

### Changes
 - Added the `puppet_metrics_dashboard::profile::dbcompiler::install` class

I think we should also add a note and example in the readme under the usage section.

needs commit squash

[suckatrash]

@coreymbe - sorry forgot one thing: could you please squash your commits? Other than that looks good to merge

[jarretlavallee]

LGTM