Add influxdb_bucket_retention_rules parameter

[SimonHoenscheid]

Add influxdb_bucket_retention_rules parameter to make retention rules configurable

Since puppetlabs/influxdb#71 is merged and released with version v1.6.0 of the influxDB module, updating the module without modifying the retention rules results in data loss on the users end. This patch just adds the option to do this.

[puppet-community-rangefinder]

puppet_operational_dashboards is a class

Breaking changes to this file MAY impact these 1 modules (near match):

• puppetlabs-puppet_operations_appliance

This module is declared in 0 of 580 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[SimonHoenscheid]

@m0dular @MartyEwings may I ask for a release after this is merged?

[MartyEwings]

@m0dular is a 90 day default with the justification that an upgrade is not impacting, cool with you?
We would need to put some config on our platforms on next upgrade to compensate

[SimonHoenscheid]

@MartyEwings

@m0dular is a 90 day default with the justification that an upgrade is not impacting, cool with you? We would need to put some config on our platforms on next upgrade to compensate

I created the PR because the mentioned change in the Influxdb module is a breaking one. This change just gives the user the option to change the default (coming from the influx module)

Influx Bucket before Influxdb 1.6.0 release:

influx bucket list
ID                      Name            Retention       Shard group duration    Organization ID         Schema Type
d3e7bebd27375b07        puppet_data     infinite        168h0m0s                c8d85d6a80ef4af3        implicit

after:

influx bucket list
ID                      Name            Retention       Shard group duration    Organization ID         Schema Type
d3e7bebd27375b07        puppet_data     2160h0m0s       168h0m0s                c8d85d6a80ef4af3        implicit

[m0dular]

I'm a little worried this would create a duplicate declaration if people are managing the initial bucket themselves. You can always manage it in Puppet code with the retention and any other params you need, but I think if there were also a $manage_initial_bucket parameter in this PR then it would be good. The other side of the coin is that infinite retention would keep using disk space, so I think we did need a default.

[m0dular]

Nevermind, I thought this was a PR to influxdb, so nothing in my last comment applies. Since ops dashboards is managing the initial bucket, adding this param and passing it to the bucket resource makes perfect sense 👍