Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MODULES-1789 add initial mod_geoip support #1083

Merged
merged 2 commits into from
Mar 24, 2015

Conversation

roman-mueller
Copy link
Contributor

This adds support for mod_geoip.
I've tested it on CentOS 6 and 7.

There is one problem with this: if you want to set GeoIPEnable in a directories parameter you must declare the class apache::mod::geoip yourself.
As the directories parameter can be an array of hashes I cannot check for the value of geoip_enable here:

    apache::vhost { 'first.example.com':
      docroot     => '/var/www/first',
      directories => [
        { path         => '/var/www/first',
          geoip_enable => 'On',
        },
      ],
    }

And because of this, I cannot automatically include it.

$output = 'All',
$enableutf8 = undef,
$scanproxyheaders = undef,
$uselastxforwarededforip = undef,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i know it'll make the variables longer, but can you please under_score them?

@roman-mueller
Copy link
Contributor Author

@igalic thanks for feedback, didn't know about bool2httpd until now.
Can you check my last commit?

I'm not sure why the build failed now, it says it exceeded 50 minutes.
That sounds like Travis CI is overloaded rather than my change breaking it.

@igalic
Copy link
Contributor

igalic commented Mar 23, 2015

it looks like travis is overloaded, i could restart the jobs and see if that helps…

igalic added a commit that referenced this pull request Mar 24, 2015
MODULES-1789 add initial mod_geoip support
@igalic igalic merged commit 0cba390 into puppetlabs:master Mar 24, 2015
@igalic
Copy link
Contributor

igalic commented Mar 24, 2015

thanks @roman-mueller!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants