Take igalic's suggestion to use bool2httpd #1400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igalic I have taken your suggestion but, to my eyes, ,the build appears to be failing because params.pp does not define |
|
@tpdownes ay |
|
thank y ou very much for your patch @tpdownes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1398 @igalic suggests replacing 2 sections of the SSL configuration Ruby template with a function designed to safely convert Booleans to their Apache On/Off equivalent. This PR implements the suggestion.
The PR should be safe because #1398 modifies the Puppet code to ensure that each variable is already a boolean with the intended default value.