(MODULES-5990) Addition of 'IncludeOptional conf-enabled/*.conf' to apache2.conf' on Debian Family OS

[david22swan]

…apache2.conf' on Debian Family OS

[ekohl]

Missing at least a slash. This will result in /etc/apache2conf-enabled/*.conf.

It's also rather ugly to do this on all distros, even those that don't have this mechanism. I wonder if we need a $conf_enable_dir that's undef on all other distros so you can test for it in the template.

[david22swan]

@ekohl Have updated the code to be along the lines of what you suggested

[david22swan]

[baurmatt]

I think this is missing something. If the folder gets included by default, it should be managed by default as well. Especially since the default for config dirs is to purge them.
If it doesn't get managed/purged, the default files shipped with e.g. Ubuntu 16.04 get included and might break some stuff.

@david22swan What do you think about it? I'm happy to fix it myself in a PR, just want your opinion if this seems reasonable.

[david22swan]

@baurmatt I recently created a pr to set it so it is no longer included by default (#1869) after it caused issues with another user. But if you have some ideas on how to improve it so that it is managed when included then I encourage you to go for it.

[baurmatt]

@david22swan Thats, of course, an option as well ;) I thought about doing this:

class apache (
...
  Optional[Stdlib::Absolutepath] $conf_enabled = $apache::params::conf_enabled,
...
) {
...
if $conf_enabled {
  file { $conf_enabled:
    ensure  => directory,
    recurse => true,
    purge    => $purge_confd,
    force     => $purge_confd,
    notify    => Class['Apache::Service'],
    require   => Package['httpd'],
  }
...
}

While writing this I realized the /etc/apache/conf-enabled is the correct directory for Debian based systems instead of conf.d, right? Should we just change the $confd_dir for Debian based systems to "${httpd_dir}/conf-enabled"?

[david22swan]

@baurmatt Sorry for the wait, I looked into what you said and the code addition looks good. However the second part, about changing the directory from conf.d, I am not so sure. Honestly my overall apache knowledge isn't the greatest and after looking into it I can't see a strong reason for it.
Could you explain your reasoning a bit more?

[baurmatt]

@david22swan No worries! :)

As far as I remember, the conf.d directory isn't available by default on Debian based systems.It's a RedHat-ish thing. On Debian based systems the folder is called conf-enabled. Therefore I think it makes sense to replace the conf.d directory with conf-enabled.

[david22swan]

@baurmatt I'm still unsure, if you want to go ahead and start work on that I won't stop you, but it's not something that would get merged in quickly and would require some serious discussion throughout my team and not just me.
Sorry for not being more help.