-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure switching of thread module works on Debian 10 / Ubuntu 20.04 #2034
Conversation
apache::mpm is a typethat may have no external impact to Forge modules. This module is declared in 174 of 575 indexed public
|
Usual thread modules are: prefork, event and worker. When switching from one thread module to another we must ensure that the old, no longer to use, thread module gets disabled. Puppet Apache module will always use the new mpm base thread modules and place them in files without mpm_ prefix. The a2dismod utility only checks for file names, not the real thread module.
Codecov Report
@@ Coverage Diff @@
## master #2034 +/- ##
==========================================
+ Coverage 57.87% 58.49% +0.61%
==========================================
Files 13 12 -1
Lines 235 212 -23
==========================================
- Hits 136 124 -12
+ Misses 99 88 -11
Continue to review full report at Codecov.
|
Disabling class uses another filename: |
Extends #1961 to also work correctly on Debian 10 and Ubuntu 20
Hi @tuxmea, |
Allow switching of thread module
there were a few things broken: * a2dismod was called with the wrong module name. at least on apache 2.4.54 on Debian 11 it is named mpm_event, not event * the paths to the files were wrong * a2dismod already purges the .load and .conf file, the exec resources are not required (even then a file resource would probably be cleaner to purge them) * Apache needs to be reloaded, so just running this priot to apache2::service isn't enough, it needs to be a notify This initially worked but was changed from mpm_event to event in puppetlabs#1961. Then it was fixed in puppetlabs#2034 by adding the exec resources, but the actual a2dismod was still broken.
there were a few things broken: * a2dismod was called with the wrong module name. at least on apache 2.4.54 on Debian 11 it is named mpm_event, not event * the paths to the files were wrong * a2dismod already purges the .load and .conf file, the exec resources are not required (even then a file resource would probably be cleaner to purge them) * Apache needs to be reloaded, so just running this priot to apache2::service isn't enough, it needs to be a notify This initially worked but was changed from mpm_event to event in puppetlabs#1961. Then it was fixed in puppetlabs#2034 by adding the exec resources, but the actual a2dismod was still broken.
Extends #1961 to also work correctly on Debian 10 and Ubuntu 20