Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSLVerify options #2081

Merged
merged 1 commit into from
Nov 23, 2020
Merged

Improve SSLVerify options #2081

merged 1 commit into from
Nov 23, 2020

Conversation

bovy89
Copy link
Contributor

@bovy89 bovy89 commented Nov 2, 2020

Enable SSLVerifyClient and SSLVerifyDepth inside locations. Add SSLVerifyClient validation. SSLCACertificate (and related options) can now be specified even without SSLVerifyClient (can be inside a location).

@bovy89 bovy89 requested a review from a team as a code owner November 2, 2020 20:39
templates/vhost/_ssl.erb Outdated Show resolved Hide resolved
@sanfrancrisko sanfrancrisko self-assigned this Nov 9, 2020
Enable SSLVerifyClient and SSLVerifyDepth inside locations. Add SSLVerifyClient validation. SSLCACertificate (and related options) can now be specified even without SSLVerifyClient (can be inside a location).

Co-authored-by: Ewoud Kohl van Wijngaarden <ekohl@users.noreply.github.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@754f843). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2081   +/-   ##
=======================================
  Coverage        ?   57.40%           
=======================================
  Files           ?       12           
  Lines           ?      216           
  Branches        ?        0           
=======================================
  Hits            ?      124           
  Misses          ?       92           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 754f843...7bcfae3. Read the comment docs.

Copy link
Contributor

@sanfrancrisko sanfrancrisko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @bovy89 and the help reviewing @ekohl 👍

@sanfrancrisko sanfrancrisko merged commit 0e67921 into puppetlabs:main Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants