-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vhost Alias and Directory declarations #212
Conversation
…at .erb can handle hash["key"]
...again I hope .erb hash processing works...
…gment. Added `options` and `addhandlers` parameters to directories.
Here's an example of this feature being used: https://github.com/nesi/puppet-gold/blob/master/manifests/install.pp#L219 |
Some reformatting to make cases easier to read
Ok, I've added tests for Alias directives and Directory blocks (singular and multiple). Because I've substituted the default Directory block, many of the parameters have already been tested. |
This is sweethotness :). Thanks for working on this! And adding tests, and using the |
Add vhost Alias and Directory declarations
Hmm. I'd love for this to be implemented as |
Yes, I did think at the end that having these as defined resources would be better, but this works, and provides a model for the resources to follow. (and I need to get a better handle on virtual and exported resources...) |
@Aethylred Is there a reason that |
hmm... so No reason other than I've used lists longer than hashes. |
Okay, thanks. Since this will make it into the 1.0.0 release I was just thinking about how I want the API to look. |
Sets up Alias declarations from a list of hashes.
Also sets up
<Directory></Directory>
blocks from a list of hashes.