Fix HEADER* and README* wildcards in IndexIgnore #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original intent of HEADER* and README* in the IndexIgnore was probably to ignore the files that are included at the top (HeaderName) and bottom (ReadmeName) of the index listing. But the wildcard will hide other files, like README.txt, so use full filenames instead.
|
|
|
Hi @keto, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original intent of HEADER* and README* in the IndexIgnore was
probably to ignore the files that are included at the top (HeaderName) and
bottom (ReadmeName) of the index listing. But the wildcard will hide other
files, like README.txt, so use full filenames instead.