-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the default version of Apache for Amazon Linux 2 #2158
Conversation
- updated minor version
apache::version is a classBreaking changes to this file WILL impact these 1 modules (exact match):This module is declared in 175 of 576 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why Ubuntu testing fails but that can't be related.
Maybe another place to check is here:
puppetlabs-apache/manifests/mod/passenger.pp
Lines 839 to 843 in 958023b
if $::operatingsystem == 'Amazon' { | |
$baseurl = 'https://oss-binaries.phusionpassenger.com/yum/passenger/el/6Server/$basearch' | |
} else { | |
$baseurl = 'https://oss-binaries.phusionpassenger.com/yum/passenger/el/$releasever/$basearch' | |
} |
AFAIK that is also not correct with Amazon 2 since it's based on EL7 while Amazon 1 was based on EL6.
I guess the root cause of the Ubuntu failed tests are unmet dependencies:
Maybe docker image or openssh* stuff has been updated I'm not familiar with the |
btw. What I have found in docs: https://github.com/puppetlabs/puppetlabs-apache#rhelcentos-7
|
Any ideas when this PR will be accepted after merging is cleared ? |
That's just testing. However, just from reading the code you can see that it will try to use EL6 repos on Amazon Linux. That should also get a conditional that it's Amazon Linux 1.
If #2158 (review) is addressed. |
- added Amazon Linux 2 support for passenger module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct from a patch perspective. I think the modules team can give some advice on the correct commit message so it meets their standards. I'm not sure if we need to squash this etc.
Everything looks good from my end so I'll go ahead and merge it :) @turnopil Thank you for realizing the need for this fix and putting in the work to get it done, hope to see more from you in the future :) @ekohl Thank you for reviewing this work and helping to get it across the line, great to see you taking advantage of the trusted contributors program :) Also regarding what you stated in your last message, in regards to the PR titles the general idea is that the title should clearly reflect what the PR is attempting to accomplish so that you can tell at a glance. Sorry if I went on for a while, wanted to be clear. |
$default
variable for Amazon Linux 2The default
httpd
package version on the Amazon Linux 2 is2.4
Based on the above we need to update the
$default
variable to support AL2