-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop mod_fastcgi support #2267
Drop mod_fastcgi support #2267
Conversation
While this look's like a good change to me and is one I would love to get in I'm not sure we can merge it. |
But as far as I could see, mod_fastcgi is not in EL6 itself. At least, https://vault.centos.org/centos/6/os/x86_64/Packages/ doesn't list it (don't have a real RHEL 6 on hand). It looks like it was previously provided through external repositories. However, https://archives.fedoraproject.org/pub/archive/epel/6/x86_64/Packages/m/ also only lists mod_fcgid, not most_fastcgi. So really, where did it come from? 6c1ed75 stopped installing it on EL7, but I can't see where it came from on EL6. 48fb00e added it, but also doesn't describe anything. #295 does describe that it once came from official archives, but even in 2013 it was abandoned for 2 years. I'd say that if it isn't in RHEL 6 itself, it's safe to drop. EPEL6 is EOL and not supported by Red Hat. Disclaimer: while I have my own employer provided Red Hat, I don't know the exact scope of partnerships. |
From my perspective at least, it's more of that the alternative to it, |
Generally speaking Red Hat is very strict in "if we don't provide the bits, we don't support it". I found https://actsupport.com/apache-php-fpm-mod-fastcgi/ which states:
Considering rpmforge is dead and even no longer online, I really wonder who is going to use it. Worse, how are you going to support it if you can't even get it to run because you don't have the bits? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, you've convinced us.
Hope you don't mind waiting for the narrow PR to be merged first though.
No, that's a good idea. Rebasing this is trivial. |
mod_fastcgi isn't part of EL7 and beyond, nor in any current Debian release. That's because upstream is dead. It also isn't part of RHEL itself and EPEL 6 is dead. Removing it from the codebase simplifies it.
Rebased |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Test failure is from a CI issue and not due to the code.
Thank's for the work. |
Please put this back in! |
Interesting. https://www.freshports.org/www/mod_fastcgi/ does have more information, like https://github.com/FastCGI-Archives which I wasn't able to find. Since I'm not able to test it, I think you'll have to come up with a PR @raybellis. |
I don't have the means or head space to build a CI test, but I can assure you that the code that was removed in these commits was working perfectly well for us on FreeBSD. I do have a workaround using custom config blobs, so this is not critical, but please do consider that major Linux distros are not the only place people run Puppet. |
My biggest concern is that mod_fastcgi is dead upstream and no development happens on it. I took that as a sign nobody would bother shipping it and I'm really surprised FreeBSD still does. |
I took it as a sign that it doesn't need any more development on it ;-) It is a dependency for running the popular RT ticket system. |
mod_fastcgi isn't part of EL7 and beyond, nor in any current Debian/Ubuntu release. That's because upstream is dead. It also isn't part of RHEL itself and EPEL 6 is dead. Removing it from the codebase simplifies it.