Sites symlinks #235
Merged
Sites symlinks #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Debian systems vhost definitions should go in sites-available and be symlinked to from sites-enabled. apache2.conf should include sites-enabled/*.conf. This updates the module to follow this behaviour. Closes puppetlabs#161. Closes puppetlabs#135
In testing the sites-enabled symlinks, it was discovered that the virtual_docroot parameter did not work on debian without also including the vhost_alias httpd mod. This corrects that behaviour.
In testing sites-enabled behaviour, it was discovered that php loading did not perform as expected on Debian due to including configuration files from mods-available instead of mods-enabled. This corrects that behaviour.
The ability to purge configs to preserve pristine working conditions is often critical to avoid breaking apache unintentionally. On many platforms the apache package will create directories into which other apache mod package will place configs. These can conflict with configs managed by puppet and cause apache service failures. This would normally be corrected by purging those stray files on the second puppet run, but in the mean time apache would have stopped. Single-run idempotency is preferable. Since Puppet cannot separately ensure => directory and purge => true, this commit uses an exec resource and mkdir to create the directories, and uses a file resource *after* all mods have been processed to do the ownership & purging.
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
changing docker spec to alpine due to issue with init on ubuntu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has more than a few small tweaks in it, but here is the summary of each commit's outcomes:
sites-enabledandsites-availablecorrectly on Debian (and fixmods-enabledloading)vhost_aliasby default ifapache::vhost::virtual_docrootis passedphp5.confforapache::mod::phpon Debian<||>because of virtual resource realization.)The bugfixes were discovered during the introduction of this feature.