Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress bad Directory comment when DocumentRoot is not set #2368

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Suppress bad Directory comment when DocumentRoot is not set #2368

merged 1 commit into from
Feb 7, 2023

Conversation

gcoxmoz
Copy link
Contributor

@gcoxmoz gcoxmoz commented Jan 14, 2023

It's valid for a DocumentRoot to be missing (docroot => false).
However, in the directories section, this leads to a confusing message:

## Directories, there should at least be a declaration for false

@gcoxmoz gcoxmoz requested a review from a team as a code owner January 14, 2023 20:15
@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 3, 2023

Closing and reopening to kick off a test.

@pmcmaw pmcmaw closed this Feb 3, 2023
@pmcmaw pmcmaw reopened this Feb 3, 2023
It's valid for a DocumentRoot to be missing (docroot => false).
However, in the directories section, this leads to a confusing message:
"## Directories, there should at least be a declaration for false"
@gcoxmoz
Copy link
Contributor Author

gcoxmoz commented Feb 3, 2023

My read of the tests that failed suggest these are problems in the tests themselves. If I'm wrong, please reaim me, but mentally I'm considering this as a green run.

@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 6, 2023

Hey @gcoxmoz yes I completely agree. I have pushed a change upstream for the mend tests, therefore I will rekick it and it should pass this time round. The SLES failure I think is transient, I will rekick it too. Apologies I needed to double check it was failing and your PR was the first I came across that was in the specific timescale I needed to test.

@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 6, 2023

Sorry having to close and reopen to kick off the mend tests properly.

@pmcmaw pmcmaw closed this Feb 6, 2023
@pmcmaw pmcmaw reopened this Feb 6, 2023
@gcoxmoz
Copy link
Contributor Author

gcoxmoz commented Feb 6, 2023

I don't mind being the guineapig here, no apology needed. So long as you see the testfails are not a Me thing, and seems like you do.

@pmcmaw
Copy link
Contributor

pmcmaw commented Feb 7, 2023

Mend failure is unrelated to PR changes.
Merging, thank you for your patience 👍

@pmcmaw pmcmaw merged commit 04d7b51 into puppetlabs:main Feb 7, 2023
@pmcmaw pmcmaw added the bugfix label Feb 7, 2023
@gcoxmoz gcoxmoz deleted the docroot-comment branch February 8, 2023 00:09
@yakatz
Copy link
Contributor

yakatz commented Jun 5, 2023

That was me - woops...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants