Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required package for kerberos auth on jammy #2403

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

chrisongthb
Copy link
Contributor

This solves #2402

@chrisongthb chrisongthb requested a review from a team as a code owner April 12, 2023 13:30
@CLAassistant
Copy link

CLAassistant commented Apr 12, 2023

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

apache::params is a class

Breaking changes to this file WILL impact these 7 modules (exact match):
Breaking changes to this file MAY impact these 4 modules (near match):

This module is declared in 176 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

ekohl
ekohl previously approved these changes Apr 12, 2023
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified https://packages.ubuntu.com/jammy/libapache2-mod-auth-kerb exists, but packages.debian.org appears to be down now so I can't check it.

@chrisongthb
Copy link
Contributor Author

Looks like libapache2-mod-auth-kerb is not available for Debian 11 bullseye:
https://packages.debian.org/search?suite=all&searchon=names&keywords=libapache2-mod-auth-kerb

Updated params.pp - please have a look - Thx!

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the diff, the you now define nss again, which previously wasn't. That package was dropped in Ubuntu 20.04.

I'm starting to wonder if it should be changed to this pattern:

$_base_mod_packages = {
  # common ones
}

$_version_mod_packages = if VERSION_CHECK {
  {
    # ...
  }
} else {
  {}
}

$mod_packages = $_base_mod_packages + $_os_mod_packages

@chrisongthb
Copy link
Contributor Author

Good idea to split it up as it is better readable. Could you look at the implementation?

ekohl
ekohl previously approved these changes Apr 13, 2023
Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is indeed what I had in mind, and moving forward it'll hopefully be easier to maintain. I'll kick off CI so see if it agrees :)

manifests/params.pp Outdated Show resolved Hide resolved
manifests/params.pp Outdated Show resolved Hide resolved
@chrisongthb
Copy link
Contributor Author

@ekohl if I got you right, it might work now.

@chrisongthb
Copy link
Contributor Author

@ekohl could you check failed CI for SLES? I did not change anything regarding SLES.

@ekohl
Copy link
Collaborator

ekohl commented Apr 17, 2023

I think it's unrelated, but I don't know SLES. This needs approval from @puppetlabs/modules before it can be merged, so I'm now counting on them to take over.

@LukasAud
Copy link
Contributor

Hi @chrisongthb, sorry for the long delay in engagement. We have been busy with essential maintenance. Could you rebase your PR to make sure its up-to-date with our current main. CI seems to be outdated as its not showing our Puppet 8 agent tests.

We will be happy to take a closer look into this PR once that is done.

@chrisongthb
Copy link
Contributor Author

@LukasAud - rebase done :)

@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 14, 2023

Thanks @chrisongthb your contribution, The changes looks good. I am taking this forward.

@Ramesh7 Ramesh7 merged commit 564dbda into puppetlabs:main Sep 14, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache::Mod::Auth_kerb does not manage required package on Ubuntu 22.04
6 participants