-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add required package for kerberos auth on jammy #2403
Conversation
apache::params is a classBreaking changes to this file WILL impact these 7 modules (exact match):Breaking changes to this file MAY impact these 4 modules (near match):This module is declared in 176 of 580 indexed public
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've verified https://packages.ubuntu.com/jammy/libapache2-mod-auth-kerb exists, but packages.debian.org appears to be down now so I can't check it.
Looks like Updated params.pp - please have a look - Thx! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the diff, the you now define nss
again, which previously wasn't. That package was dropped in Ubuntu 20.04.
I'm starting to wonder if it should be changed to this pattern:
$_base_mod_packages = {
# common ones
}
$_version_mod_packages = if VERSION_CHECK {
{
# ...
}
} else {
{}
}
$mod_packages = $_base_mod_packages + $_os_mod_packages
Good idea to split it up as it is better readable. Could you look at the implementation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is indeed what I had in mind, and moving forward it'll hopefully be easier to maintain. I'll kick off CI so see if it agrees :)
@ekohl if I got you right, it might work now. |
@ekohl could you check failed CI for SLES? I did not change anything regarding SLES. |
I think it's unrelated, but I don't know SLES. This needs approval from @puppetlabs/modules before it can be merged, so I'm now counting on them to take over. |
Hi @chrisongthb, sorry for the long delay in engagement. We have been busy with essential maintenance. Could you rebase your PR to make sure its up-to-date with our current main. CI seems to be outdated as its not showing our Puppet 8 agent tests. We will be happy to take a closer look into this PR once that is done. |
307a574
to
1b16377
Compare
1b16377
to
068fe84
Compare
@LukasAud - rebase done :) |
Thanks @chrisongthb your contribution, The changes looks good. I am taking this forward. |
This solves #2402