Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ssl_ciphers array behavior #2421

Merged
merged 1 commit into from
Jun 20, 2023
Merged

fix ssl_ciphers array behavior #2421

merged 1 commit into from
Jun 20, 2023

Conversation

SimonHoenscheid
Copy link
Contributor

fixes #2420

@SimonHoenscheid SimonHoenscheid marked this pull request as ready for review June 8, 2023 21:34
@SimonHoenscheid SimonHoenscheid requested a review from a team as a code owner June 8, 2023 21:34
@SimonHoenscheid
Copy link
Contributor Author

Diff of fixed config:

-  SSLCipherSuite          ["ECDHE-ECDSA-AES128-GCM-SHA256", "ECDHE-RSA-AES128-GCM-SHA256", "ECDHE-ECDSA-AES256-GCM-SHA384", "ECDHE-RSA-AES256-GCM-SHA384", "ECDHE-ECDSA-CHACHA20-POLY1305", "ECDHE-RSA-CHACHA20-POLY1305", "DHE-RSA-AES128-GCM-SHA256", "DHE-RSA-AES256-GCM-SHA384"]
+  SSLCipherSuite         ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384

@jordanbreen28
Copy link
Contributor

Thanks @SimonHoenscheid!
Looks like you've gotten a single acceptance test failure, are you able to take a look at this?

@SimonHoenscheid
Copy link
Contributor Author

@jordanbreen28 fixed

@jordanbreen28
Copy link
Contributor

@SimonHoenscheid nice one!
Think this is good to go once green!

jordanbreen28
jordanbreen28 approved these changes Jun 20, 2023
View reviewed changes
Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @SimonHoenscheid

@jordanbreen28 jordanbreen28 merged commit 73022e7 into puppetlabs:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenyon kenyon kenyon approved these changes

@jordanbreen28 jordanbreen28 jordanbreen28 approved these changes

@bastelfreak bastelfreak Awaiting requested review from bastelfreak bastelfreak is a code owner

@ekohl ekohl Awaiting requested review from ekohl ekohl is a code owner

@smortex smortex Awaiting requested review from smortex smortex is a code owner

Assignees
No one assigned
Labels
bugfix community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

apache::vhost define parameter ssl_cipher allows array but is not handling it correctly in template
4 participants
@SimonHoenscheid @jordanbreen28 @kenyon @ia-content