SSLProtocol, SSLCipherSuite, SSLHonorCipherOrder support in the SSL section #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for that, I will buy an "git for dummies" book to be able to do it just myself next time. |
|
I'll throw in a new PR for the other options that got smashed into the other PR after this one has been merged in (sorry for the confusion there). GitHub seems to automatically merge them in if it's based on a branch where you've made a pull request. |
| <% if @ssl_protocol -%> | ||
| SSLProtocol <%= @ssl_protocol %> | ||
| <% end -%> | ||
| <% if @ssl_chiper -%> |
| <% end -%> | ||
| <% if @ssl_cipher -%> | ||
| SSLCipherSuite <%= @ssl_cipher %> | ||
| <% end -%> |
There was a problem hiding this comment.
While you're at it, might I also suggest adding support for SSLHonorCipherOrder
There was a problem hiding this comment.
@igalic Good Idea. Thanks.
There was a problem hiding this comment.
Nice, but do not forget about the documentation, put this option into the README.md as well
blkperl
added a commit
that referenced
this pull request
Oct 1, 2013
SSLProtocol, SSLCipherSuite, SSLHonorCipherOrder support in the SSL section
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
…petlabs#378' The fix done in 2018 was not complete. There were five more code lines which inserted the optional parameters at the wrong position.
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
Fixing the fix 'Fix the docker_compose options parameter position puppetlabs#378'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single commit for #354. closes #371
Here you go.