-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSLProtocol, SSLCipherSuite, SSLHonorCipherOrder support in the SSL section #378
Conversation
Thanks for that, I will buy an "git for dummies" book to be able to do it just myself next time. |
I'll throw in a new PR for the other options that got smashed into the other PR after this one has been merged in (sorry for the confusion there). GitHub seems to automatically merge them in if it's based on a branch where you've made a pull request. |
<% if @ssl_protocol -%> | ||
SSLProtocol <%= @ssl_protocol %> | ||
<% end -%> | ||
<% if @ssl_chiper -%> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: spelled chiper instead of cipher
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paul91
<% end -%> | ||
<% if @ssl_cipher -%> | ||
SSLCipherSuite <%= @ssl_cipher %> | ||
<% end -%> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it, might I also suggest adding support for SSLHonorCipherOrder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@igalic Good Idea. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, but do not forget about the documentation, put this option into the README.md as well
SSLProtocol, SSLCipherSuite, SSLHonorCipherOrder support in the SSL section
…petlabs#378' The fix done in 2018 was not complete. There were five more code lines which inserted the optional parameters at the wrong position.
Fixing the fix 'Fix the docker_compose options parameter position puppetlabs#378'
Single commit for #354. closes #371
Here you go.