Add support for AliasMatch directives #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this really fails the tests, but I don't understand what I could be doing wrong. Looking at https://travis-ci.org/puppetlabs/puppetlabs-apache/jobs/14232351#L1134 it seems rspec swallows up the becomes As you can see the path Or am I going crazy? |
(puppetlabs#479) Extend the _aliases.erb template so that the list of hashes in `apache::vhost`'s `aliases` parameter can contain the usual `alias` hashes but also `aliasmatch` hashes, which get translated to `AliasMatch` directives. Includes basic spec tests and updated documentation in README.md. Note that these spec tests are currently only skeletons because rspec-puppet drops constructs like '$1'. See the entries marked XXX.
|
I updated the comment to disable those tests because the problem apparently really is that rspec-puppet drops |
igalic
added a commit
that referenced
this pull request
Nov 21, 2013
Add support for AliasMatch directives
antaflos
added a commit
to antaflos/puppetlabs-apache
that referenced
this pull request
Nov 25, 2013
Much like in PR puppetlabs#483 extend the _scriptalias.rb template so that the `scriptalias` parameter in `apache::vhost` can contain `aliasmatch` hashes which get translated to `ScriptAliasMatch` directives. Fixes issue puppetlabs#480. Includes basic spec tests and updated documentation in README.md. Note again that puppet-rspec silently drops `$1` when specifying test values so we match `FOO` instead of `$1`. From a simple spec test perspective there shouldn't be a difference and this is better than having no tests at all.
traylenator
pushed a commit
to traylenator/puppetlabs-apache
that referenced
this pull request
Jun 7, 2022
(MODULES-9033) Fix failing acceptance tests on all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#479) Extend the _aliases.erb template so that the list of hashes in
apache::vhost'saliasesparameter can contain the usualaliashashes but also
aliasmatchhashes, which get translated toAliasMatchdirectives.Includes basic spec tests and updated documentation in README.md.
Note: The tests for this seem to fail on my machine because of what is probably a bug in rpsec-puppet. Will see what Travis says.