Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy pass reverse fix #613

Merged
merged 3 commits into from
Feb 21, 2014
Merged

Proxy pass reverse fix #613

merged 3 commits into from
Feb 21, 2014

Conversation

dteirney
Copy link

@dteirney dteirney commented Feb 9, 2014

Updated the rspec checks to match the fixes already provided for the ProxyPassReverse directive when inside a Location.

jrwilk01 and others added 3 commits February 1, 2014 16:23
See here:
http://httpd.apache.org/docs/2.2/mod/mod_proxy.html#proxypassreverse

When enclosing ProxyPassReverse in a <Location> directive, you drop the
*first* argument, as it will be taken from the enclosing Location. The
second argument is the URL to which we are attempting to proxy.

Very simple change. Tested in my environment, works.
@dteirney
Copy link
Author

dteirney commented Feb 9, 2014

The Travis CI failure is because the Ruby 1.8.7 version tests are taking longer than the cutoff of 50 minutes, which manifests as an error. No idea why they take so long as the newer versions of Ruby are done in about half that time.

Can't see anyway to re-trigger the tests to see if the travis server was very busy at that time.

@dteirney
Copy link
Author

dteirney commented Feb 9, 2014

Travis please build this.

igalic referenced this pull request Feb 18, 2014
adopt proxy configuration as documented by @niq (Nick Kew)

   http://www.apachetutor.org/admin/reverseproxies documents the

This pattern is more resilient to shaky redirects from the backend
This commit fixes #300.
@igalic igalic mentioned this pull request Feb 21, 2014
@hunner
Copy link
Contributor

hunner commented Feb 21, 2014

Closes #602

hunner added a commit that referenced this pull request Feb 21, 2014
@hunner hunner merged commit c2f6fcb into puppetlabs:master Feb 21, 2014
traylenator pushed a commit to traylenator/puppetlabs-apache that referenced this pull request Jun 7, 2022
(MODULES-9696) remove docker_home_dirs fact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants