Add package parameters to the dav_svn mod.

[Arakmar]

Add package parameters to the dav_svn mod to be more convenient.

I also removed the custom loadfile_name as it produces a duplicate load file on Debian.
It's because load files installed by packages aren't purged on Debian.

[igalic]

Yeah, this code is the reason, init.pp

  if ! defined(File[$mod_dir]) {
    exec { "mkdir ${mod_dir}":
      creates => $mod_dir,
      require => Package['httpd'],
    }
# Don't purge available modules if an enable dir is used
    $purge_mod_dir = $purge_configs and !$mod_enable_dir
    file { $mod_dir:
      ensure => directory,
      recurse => true,
      purge => $purge_mod_dir,
      notify => Class['Apache::Service'],
      require => Package['httpd'],
    }
  }

I wonder if we should rethink that stance. By now it's pretty clear that most people want puppet to manage the configuration, rather than the package manager. Those who don't can set purge_configs => false

[underscorgan]

If this is broken in Debian this needs to be updated with a selector or something, maybe

loadfile_name => $::osfamily ? {
  'Debian' => undef,
  default  => 'dav_svn_authz_svn.load',
},

At least on RHEL-based systems httpd wouldn't start without the loadfile_name due to authz_svn being loaded before dav_svn.

[Arakmar]

@igalic Yes, I think the same. It would be better to purge this directory even if an enable mechanism is available.

@mhaskel Thanks for the explanation. Nothing is broken on Debian but it was to be consistent with files added by the Debian package. So I'll add what you've suggested.

[Arakmar]

Pull request updated.
I removed package parameters as I didn't see that the package was defined in apache::params.

[apenney]

any chance you can rebase this one for us? It's not mergable as is.

[Arakmar]

Rebase done

[hunner]

Thanks! Will wait for travis ci first.

[hunner]

Failures related to #778 ; will try to re-run them.