-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support parameters along with proxy_pass now w/ tests #914
Support parameters along with proxy_pass now w/ tests #914
Conversation
Unfortunately I didn't find time to implement the tests myself. Thanks @tfhartmann! I really appreciate that you are pushing this forward :-) |
this will need a rebase now… |
now that i've merged a different params patch |
no worries, I'll give it a rebase :) |
\o/ thank you and i'm sorry /o\ |
I also implemented a simple string method first but after a request by @apenney #764 (comment) I moved to the subhash/array method. This reflects the structure of the data better and thus seems cleaner to me. |
a8d43b7
to
0edb041
Compare
@tfhartmann @igalic @mhaskel @mark0n The subhash/array method is IMHO cleaner. But this way you cannot add these parameters: nocanon interpolate noquery (http://httpd.apache.org/docs/2.4/mod/mod_proxy.html#proxypass) |
@mkobel that's correct you cannot add them as parameters because they aren't parameters but keywords (using the language of the Apache documentation). Note that this PR supports both. |
@mark0n Thank you for your clarification! |
Thanks guys! I rebased and pushed to my branch :) |
Support parameters along with proxy_pass now w/ tests
thanks @tfhartmann @mark0n @mkobel @igalic ! |
Added tests to @mark0n PR for #764
@mhaskel I think this is what you were looking for 😄