Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support parameters along with proxy_pass now w/ tests #914

Merged
merged 4 commits into from
Nov 5, 2014

Conversation

tfhartmann
Copy link
Contributor

Added tests to @mark0n PR for #764

@mhaskel I think this is what you were looking for 😄

@mark0n
Copy link
Contributor

mark0n commented Oct 24, 2014

Unfortunately I didn't find time to implement the tests myself. Thanks @tfhartmann! I really appreciate that you are pushing this forward :-)

@igalic
Copy link
Contributor

igalic commented Oct 28, 2014

this will need a rebase now…

@igalic
Copy link
Contributor

igalic commented Oct 28, 2014

now that i've merged a different params patch _
#910

@tfhartmann
Copy link
Contributor Author

no worries, I'll give it a rebase :)

@igalic
Copy link
Contributor

igalic commented Oct 28, 2014

\o/ thank you and i'm sorry /o\

@tfhartmann
Copy link
Contributor Author

@igalic @hunner @mhaskel Is there a preferred method to pass these parameters? When I rebase, should I keep the subhash/array method that @mark0n used it #764 or the string method that @mkobel used in #910 ?

@mark0n
Copy link
Contributor

mark0n commented Oct 28, 2014

I also implemented a simple string method first but after a request by @apenney #764 (comment) I moved to the subhash/array method. This reflects the structure of the data better and thus seems cleaner to me.

@mkobel
Copy link
Contributor

mkobel commented Oct 28, 2014

@tfhartmann @igalic @mhaskel @mark0n The subhash/array method is IMHO cleaner. But this way you cannot add these parameters: nocanon interpolate noquery (http://httpd.apache.org/docs/2.4/mod/mod_proxy.html#proxypass)

@mark0n
Copy link
Contributor

mark0n commented Oct 28, 2014

@mkobel that's correct you cannot add them as parameters because they aren't parameters but keywords (using the language of the Apache documentation). Note that this PR supports both.

@mkobel
Copy link
Contributor

mkobel commented Oct 28, 2014

@mark0n Thank you for your clarification!

@tfhartmann
Copy link
Contributor Author

Thanks guys! I rebased and pushed to my branch :)

underscorgan pushed a commit that referenced this pull request Nov 5, 2014
Support parameters along with proxy_pass now w/ tests
@underscorgan underscorgan merged commit fba4862 into puppetlabs:master Nov 5, 2014
@underscorgan
Copy link
Contributor

thanks @tfhartmann @mark0n @mkobel @igalic !

@tfhartmann tfhartmann deleted the tfhartmann_proxy_pass branch November 11, 2014 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants