Add support for SSLPassPhraseDialog

[dteirney]

Initial PR for review to add support for SSLPassPhraseDialog.

https://tickets.puppetlabs.com/browse/MODULES-1518

[igalic]

hrm, yeah, I think you can collapse the whole thing by making 'builtin' the default.

[underscorgan]

@dteirney @igalic yeah, I think having ssl_pass_phrase_dialog default to builtin will clean up the template (and is a reasonable default)

@dteirney if you could also update the unit tests at https://github.com/puppetlabs/puppetlabs-apache/blob/master/spec/classes/mod/ssl_spec.rb to exercise the new parameter that would be great!

[dteirney]

I've made the change for builtin to be the default. Will add tests in the coming days. I presume we'll probably need to squash once everything is in place.

[underscorgan]

@dteirney any update on the tests?

Yes, once everything is in place we'll want to squash down to a single commit

[igalic]

ping @dteirney

[dteirney]

I'll look into the tests in the next few days, perhaps early next week. Been away on holiday for a while. Only just got back.

[dteirney]

I've squashed down the commits and added some tests following the same pattern as in worker_spec.rb.

Is there anything else that anyone thinks needs to be done for this PR before it is committed?

As an aside, ssl_conf.erb still has the block around it. From another PR I was asked to take the IfModule block out. Including IfModule still seems to be the pattern for most modules though. Is anyone looking to do a PR to remove the IfModule blocks if that is no longer the preferred pattern?

[underscorgan]

Great, thanks @dteirney.

Regarding IfModules, it's one of the things we're planning on removing in 2.0.0: https://github.com/puppetlabs/puppetlabs-apache/blob/2.0.x/DESIGN.md#get-rid-of-all-ifmodule-directives