Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RewriteMap support #990

Merged
merged 1 commit into from
Feb 17, 2015
Merged

Add RewriteMap support #990

merged 1 commit into from
Feb 17, 2015

Conversation

soerenbe
Copy link
Contributor

Here is the patch to support apache RewriteMap.

Since this is my first contribution/pull request every feedback is very wellcome.

@soerenbe
Copy link
Contributor Author

Associated ticket: https://tickets.puppetlabs.com/browse/MODULES-1689

@igalic
Copy link
Contributor

igalic commented Jan 28, 2015

@soerenbe thank you very much for this contribution.
i think we have spec thests for rewrite_stuff. would you mind adding rewrite_map to those tests as well?

@soerenbe
Copy link
Contributor Author

@igalic I will try. Last time i tried it, i didn't get all the spec tests to run on my Ubuntu 14.04 box because of some fancy ruby error. So I gave up after a hour. I will trie it tomorrow.

@soerenbe
Copy link
Contributor Author

soerenbe commented Feb 9, 2015

@igalic Ok - I got it.
It took me hours to get vagrant running, but finally I got it. I added a the test and it passes.

@underscorgan
Copy link
Contributor

Hi @soerenbe, this looks good, thanks! Could you please squash this down to a single commit, then we should be good to merge!

@igalic
Copy link
Contributor

igalic commented Feb 16, 2015

@soerenbe ping

@soerenbe
Copy link
Contributor Author

@igalic : Done.
When you need something else drop me a line.

I just realized that there is a similar (old?) pull request here: #900

igalic added a commit that referenced this pull request Feb 17, 2015
@igalic igalic merged commit 7be44e4 into puppetlabs:master Feb 17, 2015
@igalic
Copy link
Contributor

igalic commented Feb 17, 2015

@soerenbe thanks you.

re #900: sometimes pull requests are forgotten, either by us, or by their authors :(

@soerenbe soerenbe deleted the feature/master/rewritemap_support branch February 17, 2015 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants