(MODULES-10831) key is expired if all subkeys are expired #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kenyon
force-pushed
the
refresh-on-expired-subkeys
branch
from
ba05c8f
to
f615010
Compare
kenyon
force-pushed
the
refresh-on-expired-subkeys
branch
from
f615010
to
42681d2
Compare
|
This is ready. |
kenyon
force-pushed
the
refresh-on-expired-subkeys
branch
2 times, most recently
from
949c77d
to
99894a3
Compare
kenyon
force-pushed
the
refresh-on-expired-subkeys
branch
from
99894a3
to
058e794
Compare
Previously, subkeys were not considered at all in the determination of whether a key was expired. Now this looks at all of the subkeys, and if they are all expired, considers the whole key expired.
kenyon
force-pushed
the
refresh-on-expired-subkeys
branch
from
058e794
to
cd31545
Compare
|
Added tests, so now this is really ready. 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, subkeys were not considered at all in the determination of whether a key was expired. Now this looks at all of the subkeys, and if they are all expired, considers the whole key expired.