forked from evolvingweb/puppet-apt
-
Notifications
You must be signed in to change notification settings - Fork 463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CONT-581) Adding deferred function support for password field #1110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
commented
May 29, 2023
- Adding deferred function support for password fields to defer the execution from master.
92b39ad
to
2d375fd
Compare
47551c7
to
b026588
Compare
Ramesh7
commented
May 29, 2023
@@ -130,7 +130,7 @@ | |||
|
|||
it { | |||
expect(subject).to contain_apt__key("Add key: #{id} from Apt::Source my_source").that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'refreshed', | |||
id: GPG_KEY_ID, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
constant is not defined, cleanup of some old stuff.
Ramesh7
commented
May 29, 2023
|
||
file { '/etc/apt/auth.conf': | ||
ensure => $auth_conf_ensure, | ||
owner => $auth_conf_owner, | ||
group => 'root', | ||
mode => '0600', | ||
content => Sensitive("${confheadertmp}${auth_conf_tmp}"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deferred function doesn't work well with interpolation as well as nested hash, so passing variable.
64d6677
to
8cbadde
Compare
GSPatton
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.