Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(CONT-581) Adding deferred function support for password field #1110

Merged
merged 1 commit into from
May 30, 2023
Merged

(CONT-581) Adding deferred function support for password field #1110

merged 1 commit into from
May 30, 2023

Conversation

Ramesh7
Copy link

@Ramesh7 Ramesh7 commented May 29, 2023

  • Adding deferred function support for password fields to defer the execution from master.

@Ramesh7 Ramesh7 requested a review from a team as a code owner May 29, 2023 08:39
@puppet-community-rangefinder
Copy link

apt is a class

Breaking changes to this file WILL impact these 252 modules (exact match):
Breaking changes to this file MAY impact these 47 modules (near match):

This module is declared in 235 of 580 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@Ramesh7 Ramesh7 force-pushed the CONT-581 branch 2 times, most recently from 92b39ad to 2d375fd Compare May 29, 2023 09:28
@Ramesh7 Ramesh7 force-pushed the CONT-581 branch 3 times, most recently from 47551c7 to b026588 Compare May 29, 2023 11:25
Ramesh7
Ramesh7 commented May 29, 2023
View reviewed changes
spec/defines/source_spec.rb
@@ -130,7 +130,7 @@

it {
expect(subject).to contain_apt__key("Add key: #{id} from Apt::Source my_source").that_comes_before('Apt::Setting[list-my_source]').with(ensure: 'refreshed',
id: GPG_KEY_ID,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

constant is not defined, cleanup of some old stuff.

Ramesh7
Ramesh7 commented May 29, 2023
View reviewed changes
manifests/init.pp

file { '/etc/apt/auth.conf':
ensure => $auth_conf_ensure,
owner => $auth_conf_owner,
group => 'root',
mode => '0600',
content => Sensitive("${confheadertmp}${auth_conf_tmp}"),
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deferred function doesn't work well with interpolation as well as nested hash, so passing variable.

@Ramesh7 Ramesh7 force-pushed the CONT-581 branch 2 times, most recently from 64d6677 to 8cbadde Compare May 29, 2023 11:33
@GSPatton GSPatton merged commit 91c8762 into main May 30, 2023
@GSPatton GSPatton deleted the CONT-581 branch May 30, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSPatton GSPatton GSPatton approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ramesh7 @GSPatton